aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard
verified publisher icon aws

feat(pipes-sources): add Kinesis and DynamoDB

Open msambol opened this issue 1 year ago • 13 comments

Closes #29378, #29377.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

msambol avatar Mar 14 '24 02:03 msambol

@nmussy Feel like reviewing a big one? 😄

msambol avatar Mar 22 '24 23:03 msambol

I'll have a look on Monday 👍

nmussy avatar Mar 23 '24 04:03 nmussy

I'll give it another overall look tomorrow, I should be able to give it community approval now

nmussy avatar Mar 29 '24 18:03 nmussy

I'll give it another overall look tomorrow, I should be able to give it community approval now

Nice! And thank you. Will be good to get this in, there are ~10 other sources/targets I want to add.

msambol avatar Mar 29 '24 18:03 msambol

@nmussy This should be cleaner now? I appreciate the thorough review, thank you!

msambol avatar Mar 31 '24 22:03 msambol

@TheRealAmazonKendra I think this is ready for another look... thank you for your feedback.

msambol avatar Apr 09 '24 17:04 msambol

@TheRealAmazonKendra Any further thoughts on this one?

msambol avatar May 03 '24 22:05 msambol

@TheRealAmazonKendra when you have time, I'd love another pass on this so I can work on the other sources. Thanks!

msambol avatar May 21 '24 22:05 msambol

@TheRealAmazonKendra Have time for a review this week? I'd love to push forward on the Pipes features.

msambol avatar Jun 17 '24 21:06 msambol

@TheRealAmazonKendra Have time for a review this week? I'd love to push forward on the Pipes features.

Or maybe @GavinZZ can have a look at this one?

RaphaelManke avatar Jun 22 '24 09:06 RaphaelManke

I will take a look but since @TheRealAmazonKendra has already reviewed and left feedback, I would love her to have the final approval. I can help reaching out to her internally and asking for her attention on this PR.

GavinZZ avatar Jun 24 '24 23:06 GavinZZ

I would love to use this module, thanks a lot!

vvo avatar Jun 25 '24 08:06 vvo

Is this still just awaiting a final sign-off before a merge, or is there more to it? It would be nice to have official support for these sources.

davidmjames avatar Aug 14 '24 15:08 davidmjames

I would also like to see this merged.

garysassano avatar Aug 31 '24 16:08 garysassano

@TheRealAmazonKendra Gentle poke here. Possible to give this another pass?

msambol avatar Sep 13 '24 17:09 msambol

@msambol I've reached out to Kendra just now internally. She's on leave right now, but once I hear back from her, if she has capacity will let her do the final review; if she doesn't, I'll review and approve it.

GavinZZ avatar Sep 13 '24 18:09 GavinZZ

@GavinZZ Thanks for the review! I know this is a large one.

msambol avatar Sep 26 '24 19:09 msambol

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ecba4fa2c25d57cfd8d0877f7573c198e0993d47
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Sep 26 '24 19:09 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 26 '24 20:09 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Sep 26 '24 20:09 github-actions[bot]