aws-cdk
aws-cdk copied to clipboard
feat(events-targets): support for `RedshiftDataParameters`
Issue # (if applicable)
Closes #15712. Closes #31017.
Reason for this change
RedshiftDataParameters allow for a redshift query to be scheduled. This feature adds that in
Description of changes
Added in the event target and the parameter into aws-events
Description of how you validated changes
Added unit tests + integration test
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Clarification request: One workflow is failing, and I am not sure what the reason is?
@Mergifyio update
update
❌ Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/repo-metrics-monthly.yml without workflows permission
update
❌ Mergify doesn't have permission to update
Is this an issue on my end?
@Mergifyio update
update
✅ Branch has been successfully updated
@jfuss @TheRealAmazonKendra Could I get a review please? Thank you
bump, need this!
@jfuss @TheRealAmazonKendra I'm still waiting for a review, I've done all the changes requested :)
Bump
bump @jfuss @TheRealAmazonKendra
@jfuss @TheRealAmazonKendra Are there still issues with this PR? I've done everything that's asked, but I haven't gotten a response from my changes. I've also given points for the other queries for my justification. Is there anything left to do?
Can I get some indication on what my next steps are please?
@TheRealAmazonKendra @jfuss still waiting
@jfuss , I've now also made the database field mandatory, since it was required by CloudFormation, and did not have a default value.
bump
@jfuss, I'm confused on the next steps...
bump
@mergifyio update
update
✅ Branch has been successfully updated
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
@paulhcsun, not too sure, but it seems that it's not an issue with my PR right?
@Mergifyio update
update
✅ Branch has been successfully updated
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: 2f310e0c0ee9d87a0256eae8d2de534790b96f54
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.