aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(events-targets): support for `RedshiftDataParameters`

Open Rizxcviii opened this issue 1 year ago • 19 comments

Issue # (if applicable)

Closes #15712. Closes #31017.

Reason for this change

RedshiftDataParameters allow for a redshift query to be scheduled. This feature adds that in

Description of changes

Added in the event target and the parameter into aws-events

Description of how you validated changes

Added unit tests + integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Rizxcviii avatar Mar 12 '24 15:03 Rizxcviii

Clarification request: One workflow is failing, and I am not sure what the reason is?

Rizxcviii avatar Mar 14 '24 11:03 Rizxcviii

@Mergifyio update

TheRealAmazonKendra avatar Mar 21 '24 18:03 TheRealAmazonKendra

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/repo-metrics-monthly.yml without workflows permission

mergify[bot] avatar Mar 21 '24 18:03 mergify[bot]

update

❌ Mergify doesn't have permission to update

Is this an issue on my end?

Rizxcviii avatar Mar 21 '24 22:03 Rizxcviii

@Mergifyio update

Rizxcviii avatar Mar 23 '24 00:03 Rizxcviii

update

✅ Branch has been successfully updated

mergify[bot] avatar Mar 23 '24 00:03 mergify[bot]

@jfuss @TheRealAmazonKendra Could I get a review please? Thank you

Rizxcviii avatar Mar 26 '24 14:03 Rizxcviii

bump, need this!

manmartgarc avatar Apr 03 '24 01:04 manmartgarc

@jfuss @TheRealAmazonKendra I'm still waiting for a review, I've done all the changes requested :)

Rizxcviii avatar Apr 15 '24 21:04 Rizxcviii

Bump

manmartgarc avatar Apr 30 '24 05:04 manmartgarc

bump @jfuss @TheRealAmazonKendra

Rizxcviii avatar May 07 '24 15:05 Rizxcviii

@jfuss @TheRealAmazonKendra Are there still issues with this PR? I've done everything that's asked, but I haven't gotten a response from my changes. I've also given points for the other queries for my justification. Is there anything left to do?

Rizxcviii avatar May 15 '24 17:05 Rizxcviii

Can I get some indication on what my next steps are please?

Rizxcviii avatar Jul 02 '24 09:07 Rizxcviii

@TheRealAmazonKendra @jfuss still waiting

Rizxcviii avatar Jul 31 '24 19:07 Rizxcviii

@jfuss , I've now also made the database field mandatory, since it was required by CloudFormation, and did not have a default value.

Rizxcviii avatar Aug 04 '24 15:08 Rizxcviii

bump

manmartgarc avatar Aug 24 '24 20:08 manmartgarc

@jfuss, I'm confused on the next steps...

Rizxcviii avatar Aug 24 '24 20:08 Rizxcviii

bump

noel-cashrewards avatar Aug 25 '24 12:08 noel-cashrewards

@mergifyio update

paulhcsun avatar Aug 29 '24 21:08 paulhcsun

update

✅ Branch has been successfully updated

mergify[bot] avatar Aug 29 '24 21:08 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 29 '24 22:08 mergify[bot]

@paulhcsun, not too sure, but it seems that it's not an issue with my PR right?

Rizxcviii avatar Aug 29 '24 23:08 Rizxcviii

@Mergifyio update

Rizxcviii avatar Aug 30 '24 09:08 Rizxcviii

update

✅ Branch has been successfully updated

mergify[bot] avatar Aug 30 '24 09:08 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2f310e0c0ee9d87a0256eae8d2de534790b96f54
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Aug 30 '24 10:08 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 30 '24 10:08 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Aug 30 '24 10:08 github-actions[bot]