aws-cdk
aws-cdk copied to clipboard
aws
fix(apigatewayv2): correct NuGet package naming
Issue # (if applicable)
Closes #
Reason for this change
Currently the naming of the API Gateway V2 NuGet packages are very different from what is expected as you can see blow in the global using example.
global using Amazon.CDK.AWS.APIGateway;
global using Amazon.CDK.AWS.Apigatewayv2;
global using Amazon.CDK.AwsApigatewayv2Authorizers;
global using Amazon.CDK.AwsApigatewayv2Integrations;
Description of changes
Adding and correcting .jsiirc.json with the right package names. The new global using will be reflected like this.
global using Amazon.CDK.AWS.APIGateway;
global using Amazon.CDK.AWS.APIGatewayV2;
global using Amazon.CDK.AWS.APIGatewayV2.Authorizers;
global using Amazon.CDK.AWS.APIGatewayV2.Integrations;
Description of how you validated changes
Package CDK and see the right NuGet package names.
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Exemption Request
This PR doesn't contain any functional code changes and only covers package naming.
@kaizencc @xazhao Is this something that's missing in the stabilization docs?
There are many more packages which aren't correct.
Amazon.CDK.AwsArczonealshift
Amazon.CDK.AwsB2Bi
Amazon.CDK.AwsBackupgateway
Amazon.CDK.AwsCleanrooms
Amazon.CDK.AwsDatazone
Amazon.CDK.AwsEntityresolution
Amazon.CDK.AwsHealthimaging
Amazon.CDK.AwsMediapackagev2
Amazon.CDK.AwsNeptunegraph
Amazon.CDK.AwsOsis
Amazon.CDK.AwsPcaconnectorad
Amazon.CDK.AwsProton
Amazon.CDK.AwsS3Express
Amazon.CDK.AwsShield
Amazon.CDK.AwsVerifiedpermissions
Amazon.CDK.AwsWorkspacesthinclient
Amazon.CDK.AwsWorkspaceweb
I can expand the PR to include those as well?
@mrgrain I have pushed the fix for the other packages are well. Apparently in the _jsiirc.json files the dotnet sections are set to package instead of namespace
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: 0cce18433554e2ea3e705e2af902171272e88e08
- Result: FAILED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.
✅ A exemption request has been requested. Please wait for a maintainer's review.
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.
✅ A exemption request has been requested. Please wait for a maintainer's review.