aws-cdk
aws-cdk copied to clipboard
aws
feat(codepipeline): `GitPullRequestFilter` for pipeline trigger
Issue # (if applicable)
Closes #29126.
Related PR: https://github.com/aws/aws-cdk/pull/29127 Perhaps if one merges, the other will cause a conflict.
Reason for this change
We would be good to trigger pipelines by git pull request filters.
- CFn and API docs
- https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitconfiguration.html
- https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitpullrequestfilter.html
- https://docs.aws.amazon.com/codepipeline/latest/APIReference/API_GitPullRequestFilter.html
Description of changes
Add gitPullRequestFilter parameter with new interface into GitConfiguration interface.
Description of how you validated changes
Both unit and integ tests.
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
@lpizzinidev
Thanks for your review! I changed and commented. Could you please take a look at them?
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
@GavinZZ Thanks for your approval.
It seems that the label pr/do-not-merge is attached, could you please handle this?
It was actually me who added that label, unintentionally acting as the bot while fixing our broken automation.
I just added the same label to your other filter PR because I was seeing that there are some opportunities to improve this contract. As this is going into a stable module, once they're in there we don't really have flexibility to change it after.
I'll provide a thorough response that encapsulates what I'd like to see across both PRs on Monday.
@TheRealAmazonKendra
Have you had a chance to look at the PR? I would be glad to get your opinion if you have any.
So do I understand it right this is stalled because @TheRealAmazonKendra says there are apportunities to improve it, without saying what those opportunities are? Why not merge this one for the people who are waiting for it and add the improvements later?
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.
@TheRealAmazonKendra @GavinZZ
If it takes a little more time, could you put the do-not-close label on this PR and the other one? Otherwise, it will be automatically closed.
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.
I'll check with Kendra to see if she can provide the detail on her thought soon. If not, I agree with @jochemd that we can merge this PR first to unblock people waiting for this feature and can have follow-up PRs.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: bdb348b71e8dcb5cbf740261debb4ad16f142cee
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).