aws-cdk
aws-cdk copied to clipboard
feat(codepipeline): `GitPushFilter` with branches and file paths for trigger
Issue # (if applicable)
Closes #29124.
Related PR: https://github.com/aws/aws-cdk/pull/29128 Perhaps if one merges, the other will cause a conflict.
Reason for this change
We would be good to trigger pipelines by GitPushFilter with branches and file paths.
- CFn docs
- https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitpushfilter.html
- https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitbranchfiltercriteria.html
- https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitfilepathfiltercriteria.html
Description of changes
Add props:
- branchesExcludes
- branchesIncludes
- filePathsExcludes
- filePathsIncludes
Description of how you validated changes
Both unit and integ tests.
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.
@comcalvi
I fixed the conflicts caused by the other PR that was merged.
The other PR had been attached the do-not-merge
label as well as this PR, but @GavinZZ detached the label and merged the PR (see: https://github.com/aws/aws-cdk/pull/29128#pullrequestreview-2053594036). So could you please detach the label from this PR and merge it?
Been here for a while, looks ready, this PR needs some love :) ! Any ETA please?
@comcalvi
Could you please take a look at this?
I fixed the conflicts caused by the other PR that was merged.
The other PR had been attached the do-not-merge label as well as this PR, but @GavinZZdetached the label and merged the PR (see: #29128 (review)). So could you please detach the label from this PR and merge it?
@GavinZZ
Thanks for your approval. Could you please detach the 'do-not-merge' label, and merge the PR?
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
@GavinZZ
The merge seems to have failed. Could you please retry?
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: e22a8f2c45a3b012da91f7ff8063bdec5ef27fac
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Why was it reverted?
I was really looking forward to this PR being released in the next version. 😭
That is really unfortunate. I'm in the process of asking the maintainer.
https://github.com/aws/aws-cdk/pull/30462#issuecomment-2154595664