aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(codepipeline): `GitPushFilter` with branches and file paths for trigger

Open go-to-k opened this issue 1 year ago • 1 comments

Issue # (if applicable)

Closes #29124.

Related PR: https://github.com/aws/aws-cdk/pull/29128 Perhaps if one merges, the other will cause a conflict.

Reason for this change

We would be good to trigger pipelines by GitPushFilter with branches and file paths.

  • CFn docs
    • https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitpushfilter.html
    • https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitbranchfiltercriteria.html
    • https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitfilepathfiltercriteria.html

Description of changes

Add props:

  • branchesExcludes
  • branchesIncludes
  • filePathsExcludes
  • filePathsIncludes

Description of how you validated changes

Both unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

go-to-k avatar Feb 16 '24 05:02 go-to-k

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation avatar May 14 '24 00:05 aws-cdk-automation

@comcalvi

I fixed the conflicts caused by the other PR that was merged.

The other PR had been attached the do-not-merge label as well as this PR, but @GavinZZ detached the label and merged the PR (see: https://github.com/aws/aws-cdk/pull/29128#pullrequestreview-2053594036). So could you please detach the label from this PR and merge it?

go-to-k avatar May 14 '24 05:05 go-to-k

Been here for a while, looks ready, this PR needs some love :) ! Any ETA please?

amine-mf avatar May 27 '24 13:05 amine-mf

@comcalvi

Could you please take a look at this?

I fixed the conflicts caused by the other PR that was merged.

The other PR had been attached the do-not-merge label as well as this PR, but @GavinZZdetached the label and merged the PR (see: #29128 (review)). So could you please detach the label from this PR and merge it?

go-to-k avatar May 27 '24 15:05 go-to-k

@GavinZZ

Thanks for your approval. Could you please detach the 'do-not-merge' label, and merge the PR?

go-to-k avatar May 28 '24 01:05 go-to-k

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar May 28 '24 01:05 mergify[bot]

@GavinZZ

The merge seems to have failed. Could you please retry?

go-to-k avatar Jun 02 '24 14:06 go-to-k

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jun 03 '24 21:06 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e22a8f2c45a3b012da91f7ff8063bdec5ef27fac
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Jun 03 '24 21:06 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jun 03 '24 21:06 mergify[bot]

Why was it reverted?

eriktisme avatar Jun 07 '24 09:06 eriktisme

I was really looking forward to this PR being released in the next version. 😭

moltar avatar Jun 07 '24 09:06 moltar

That is really unfortunate. I'm in the process of asking the maintainer.

https://github.com/aws/aws-cdk/pull/30462#issuecomment-2154595664

go-to-k avatar Jun 07 '24 11:06 go-to-k