aws-cdk
aws-cdk copied to clipboard
fix(cognito-identitypool-alpha): inconvenient IdentityPoolProviderUrl.userPool()
Reason for this change
IdentityPoolProviderUrl.userPool()
requires a string url
currently.
The description is "User Pool Provider Url".
It should be `${userPool.userPoolProviderName}:${userPoolClient.userPoolClientId}`
.
UserPool
has an attribute userPoolProviderUrl
which description is "User Pool Provider Url", but confusingly, it cannot be specified to IdentityPoolProviderUrl.userPool()
.
The format of the identity provider identifier isn't well documented. See SetIdentityPoolRoles API reference for example of User Pool's identity provider identifier.
Description of changes
This PR fixes IdentityPoolProviderUrl.userPool()
to accept UserPool
and UserPoolClient
instead of a string url
.
It generates a correct identifier described above.
Description of how you validated changes
Existing integration test generates an identifier as described above. The snapshot won't be changed by this PR.
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
BREAKING CHANGE: The argument of IdentityPoolProviderUrl.userPool()
has been changed from url: string
to userPool: UserPool, userPoolClient: UserPoolClient
. If you want to specify custom identifier string, use IdentityPoolProviderUrl.custom()
instead.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Exemption Request The snapshot should not be changed.
Updated BREAKING CHANGE in description
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
@Mergifyio update
update
❌ Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml
without workflows
permission
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: d90abe298332514aade2eb850366ed2324c176ef
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).