aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

eks: addCdk8sChart does not allow overwrite flag

Open gkaskonas opened this issue 2 years ago • 1 comments

Describe the bug

The function uses KubernetManifest under the hood so it should allow overwrite

Expected Behavior

  const chart = new Chart(k8sApp, "chart", {
    namespace: NAMESPACE,
  });

  cluster.addCdk8sChart("chart", chart, {
    overwrite: true,
  });

This should work

Current Behavior

Argument of type '{ overwrite: boolean; }' is not assignable to parameter of type 'KubernetesManifestOptions'.
  Object literal may only specify known properties, and 'overwrite' does not exist in type 'KubernetesManifestOptions'.ts(2345)

Reproduction Steps

export function create(app: DCApplication, k8sApp: App): void {
  const { stack, cluster } = createResources(app);

  const chart = new Chart(k8sApp, "chart", {
    namespace: NAMESPACE,
  });

  cluster.addCdk8sChart("chart", chart, {
    overwrite: true,
  });
}

const app = new DCApplication();
const k8sApp = new App();
create(app, k8sApp);

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

v2.80.0

Framework Version

No response

Node.js Version

16

OS

Mac OS

Language

Typescript

Language Version

4.9.5

Other information

No response

gkaskonas avatar Jun 07 '23 08:06 gkaskonas

addCdk8sChart() comes with KubernetesManifestOptions. We need to add this new option for that before we are allowed to use it. I am making it a p2 feature request and we welcome any pull requests.

pahud avatar Jun 07 '23 15:06 pahud