aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

chore: add core team members to mergify and merit badger

Open kaizencc opened this issue 3 years ago • 5 comments

From now on, we need to keep our core members in sync between mergify and merit badger. I can't think of a good way to automate this (yet) while keeping the github actions separate. We could simply filter for PRs that have the contribution/core label that mergify adds, but there is a race condition here and contribution/core may not be added before the merit badger is run.

kaizencc avatar Sep 21 '22 16:09 kaizencc

gitpod-io[bot] avatar Sep 21 '22 16:09 gitpod-io[bot]

I am not sure but maybe the username for bots should be dependabot[bot] and mergify[bot]?

pahud avatar Sep 22 '22 14:09 pahud

The bots should be correctly ignored by #22192. I'm wary of adding [bot] to the list of ignore usernames because the [ keyword will mess with the input and isn't allowed for normal usernames anyway. The docs also point to ignoring bot accounts using if conditions rather than anything else.

kaizencc avatar Sep 22 '22 16:09 kaizencc

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 22 '22 16:09 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 23 '22 15:09 mergify[bot]

But... I want a badge...

TheRealAmazonKendra avatar Sep 25 '22 18:09 TheRealAmazonKendra

@Mergifyio update

TheRealAmazonKendra avatar Sep 25 '22 18:09 TheRealAmazonKendra

update

✅ Branch has been successfully updated

mergify[bot] avatar Sep 25 '22 18:09 mergify[bot]

@Mergifyio requeue

TheRealAmazonKendra avatar Sep 25 '22 18:09 TheRealAmazonKendra

requeue

❌ This pull request head commit has not been previously disembarked from queue.

mergify[bot] avatar Sep 25 '22 18:09 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 25 '22 19:09 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4a6c15c3881989d8853211448d61cb27371a6c6d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Sep 25 '22 19:09 aws-cdk-automation