aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

fix(cloudfront): error not thrown when a construct with EdgeFunction is created multiple times

Open yamatatsu opened this issue 3 years ago • 3 comments

fix: #16151

I have confirmed the reproduction in unit test and fixed it.

cause

The scope of this lambda function is the edge stack created for the stack. So the path of this lambda function is decided by only id whatever the EdgeFunction path.


All Submissions:

Adding new Unconventional Dependencies:

  • [ ] This PR adds new unconventional dependencies following the process described here

New Features

  • [ ] Have you added the new feature to an integration test?
    • [ ] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

yamatatsu avatar Aug 27 '22 04:08 yamatatsu

gitpod-io[bot] avatar Aug 27 '22 04:08 gitpod-io[bot]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Sep 22 '22 00:09 aws-cdk-automation

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a36cf1294e045f5617f2abe436c909f3edab2997
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Sep 26 '22 08:09 aws-cdk-automation

This PR has been deemed to be abandoned, and will be closed. Please create a new PR for these changes if you think this decision has been made in error.

TheRealAmazonKendra avatar Oct 14 '22 00:10 TheRealAmazonKendra