aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(logs): add dimensions to metric filter

Open iRoachie opened this issue 1 year ago • 4 comments

Allows attaching dimensions to a metric filter.

Uses the API design suggested by @marcogrcr in his comment which is agreed on.

resolves #16999


All Submissions:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

iRoachie avatar Aug 18 '22 03:08 iRoachie

gitpod-io[bot] avatar Aug 18 '22 03:08 gitpod-io[bot]

@rix0rrr, @peterwoodworth could you review this?

iRoachie avatar Aug 18 '22 13:08 iRoachie

Updated the description of the pull request

iRoachie avatar Aug 18 '22 17:08 iRoachie

@TheRealAmazonKendra Changes made

iRoachie avatar Sep 26 '22 13:09 iRoachie

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 26 '22 15:09 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 26 '22 19:09 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9e1a5ca310d0d9fea47ceb7192625435af18806d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Sep 26 '22 19:09 aws-cdk-automation