aws-cdk
aws-cdk copied to clipboard
feat(events-targets): add role support for sqs target
All Submissions:
- [x] Have you followed the guidelines in our Contributing guide?
Adding new Unconventional Dependencies:
- [x] This PR adds new unconventional dependencies following the process described here
New Features
- [x] Have you added the new feature to an integration test?
- [ ] Did you use
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?
- [ ] Did you use
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Hello,
Thank you for taking time and submitting changes for review!
Please be advised that some of the integration tests failed. You can see the full output here.
Cheers!
Hey,
I am having a trouble running yarn integ
. Can you kindly run it and fix any issues for me?
I stand corrected. It's failing in where I did not make any change.
@aws-cdk-containers/ecs-service-extensions: Error: integ-runner exited with error code 1
Integ tests for aws-events-targets
are passing.
@aws-cdk/aws-events-targets: UNCHANGED batch/integ.job-definition-events 2.539s
@aws-cdk/aws-events-targets: UNCHANGED event-bus/integ.event-bus 2.542s
@aws-cdk/aws-events-targets: UNCHANGED codepipeline/integ.pipeline-event-target 2.637s
@aws-cdk/aws-events-targets: UNCHANGED lambda/integ.events 2.645s
@aws-cdk/aws-events-targets: UNCHANGED aws-api/integ.aws-api 2.649s
@aws-cdk/aws-events-targets: UNCHANGED kinesis-firehose/integ.kinesis-firehose-stream 2.715s
@aws-cdk/aws-events-targets: UNCHANGED kinesis/integ.kinesis-stream 2.643s
@aws-cdk/aws-events-targets: UNCHANGED sqs/integ.sqs-event-rule-target 2.529s
@aws-cdk/aws-events-targets: UNCHANGED sns/integ.sns-event-rule-target 2.583s
@aws-cdk/aws-events-targets: UNCHANGED codebuild/integ.project-events 2.912s
@aws-cdk/aws-events-targets: Snapshot Results:
@aws-cdk/aws-events-targets: Tests: 13 passed, 13 total
@aws-cdk/aws-events-targets: Tests successful. Total time (14.7s) | /codebuild/output/src016164706/src/github.com/aws/aws-cdk/node_modules/jest/bin/jest.js (11.3s) | integ-runner (3.4s)
@aws-cdk/aws-events-targets: Done in 48.57s.
I stand corrected. It's failing in where I did not make any change.
@aws-cdk-containers/ecs-service-extensions: Error: integ-runner exited with error code 1
Integ tests for
aws-events-targets
are passing.@aws-cdk/aws-events-targets: UNCHANGED batch/integ.job-definition-events 2.539s @aws-cdk/aws-events-targets: UNCHANGED event-bus/integ.event-bus 2.542s @aws-cdk/aws-events-targets: UNCHANGED codepipeline/integ.pipeline-event-target 2.637s @aws-cdk/aws-events-targets: UNCHANGED lambda/integ.events 2.645s @aws-cdk/aws-events-targets: UNCHANGED aws-api/integ.aws-api 2.649s @aws-cdk/aws-events-targets: UNCHANGED kinesis-firehose/integ.kinesis-firehose-stream 2.715s @aws-cdk/aws-events-targets: UNCHANGED kinesis/integ.kinesis-stream 2.643s @aws-cdk/aws-events-targets: UNCHANGED sqs/integ.sqs-event-rule-target 2.529s @aws-cdk/aws-events-targets: UNCHANGED sns/integ.sns-event-rule-target 2.583s @aws-cdk/aws-events-targets: UNCHANGED codebuild/integ.project-events 2.912s @aws-cdk/aws-events-targets: Snapshot Results: @aws-cdk/aws-events-targets: Tests: 13 passed, 13 total @aws-cdk/aws-events-targets: Tests successful. Total time (14.7s) | /codebuild/output/src016164706/src/github.com/aws/aws-cdk/node_modules/jest/bin/jest.js (11.3s) | integ-runner (3.4s) @aws-cdk/aws-events-targets: Done in 48.57s.
These tests are using the events-target
construct in their tests, so the changes here are causing that failure. This indicates that this change, as is, could cause breaking changes for current customers. @otaviomacedo's comment above addresses where that's being caused.
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: 43dc976964dd5f2581755f09b59bb13656276238
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.