feat: allow notification resource handler to get deployed within a vpc (closes #20903)

[falkvonohlen]

In an monitored AWS account it might be necessary to deploy any lambda inside a VPC. This causes the CDK deployment to fail, if Bucket.addEventNotification() is called, as it creates a utility lambda without a VPC attachment. This pull requests adds an optional attribute to the S3Bucket that can be used to provided a VPC to which the lambda gets deployed.

Fixes https://github.com/aws/aws-cdk/issues/20903

All Submissions:

• [x] Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• [ ] This PR adds new unconventional dependencies following the process described here

New Features

• [ ] Have you added the new feature to an integration test?
  • [ ] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io[bot]]

[falkvonohlen]

Hi,

I don`t see why the build is failing. It has something to do with the dependencies outside of the areas I touched. Could someone please have a look on the build result and let me know what I need to!

Thanks Falk

[mrgrain]

@mergifyio update

[mrgrain]

@falkvonohlen Let's see if updating with the latest changes helps

[mergify[bot]]

update

✅ Branch has been successfully updated

[falkvonohlen]

I actually added the ec2 dependency in a separate commit as I thought it would solve my issue, but reverted it now. However I still don`t see why the build is failing.

[TheRealAmazonKendra]

@Mergifyio update

[mergify[bot]]

update

✅ Branch has been successfully updated

[aws-cdk-automation]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: decc223d35d4075d1581c2bedf327ace332f3948
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[TheRealAmazonKendra]

This PR has been deemed to be abandoned, and will be closed. Please create a new PR for these changes if you think this decision has been made in error.