feat(core) - refactor logical ID for nested-stacks (under feature flag)

[ntachukwu]

If I have a top level stack called NetworkStack and a nested stack under it called VpcStack, CDK generates this extra-fluffy path: NetworkStack/VpcStack.NestedStack/VpcStack.NestedStackResource The .NestedStack and .NestedStackResource are both verbose and a little annoying.

Similarly, as mentioned in issue 18053 construct id of the nested stack occurred twice in its logical id.

What this PR is attempting to do..

• [ ] Change the ID returned by the getLogicalId method in stack.ts
• [ ] more

All Submissions:

• [ ] Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• [ ] This PR adds new unconventional dependencies following the process described here

New Features

• [ ] Have you added the new feature to an integration test?
  • [ ] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io[bot]]

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 0797bb67a67b7b3e35e42d6688c38a99551dbe13
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.