aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(servicecatalogappregistry): add sharing of applications and attribute groups

Open mackalex opened this issue 3 years ago • 5 comments

This PR adds sharing capability to the Application and Attribute Group constructs for Service Catalog AppRegistry. Users who have enabled AWS Organizations in their AWS account can now share their AppRegistry Application and Attribute Groups with accounts in their organization, organizational units (OUs), IAM roles, and IAM users. This provides CDK parity with the support of cross-account sharing of Applications and Attribute Groups which was released as an AppRegistry feature.


All Submissions:

Adding new Unconventional Dependencies:

  • [ ] This PR adds new unconventional dependencies following the process described here

New Features

  • [x] Have you added the new feature to an integration test?
    • [x] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license


Co-authored by: Aidan Crank

mackalex avatar Jun 23 '22 14:06 mackalex

gitpod-io[bot] avatar Jun 23 '22 14:06 gitpod-io[bot]

need update table of contents.

arcrank avatar Jun 23 '22 15:06 arcrank

Any update?

arcrank avatar Jul 08 '22 22:07 arcrank

@mackalex When you merge from live, please use @Mergifyio update instead of the update branch button. The mergify command doesn't dismiss reviews so we can more easily tell when changes have been made that are ready for a new review.

TheRealAmazonKendra avatar Aug 10 '22 23:08 TheRealAmazonKendra

Putting this back into changes requested to reflect the status.

@TheRealAmazonKendra Hi Kendra, I'm looking for an additional approval or signoff on the requested changes so I can go ahead and merge this in. Thanks in advance!

mackalex avatar Aug 17 '22 16:08 mackalex

Apologies for neglecting this one. I'll take another look on Monday.

TheRealAmazonKendra avatar Aug 22 '22 05:08 TheRealAmazonKendra

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 22 '22 16:08 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Aug 22 '22 16:08 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 19a87dcdca25353dcf40ec2069283fbc5560825e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Aug 22 '22 16:08 aws-cdk-automation