aws-application-networking-k8s icon indicating copy to clipboard operation
aws-application-networking-k8s copied to clipboard

Add TLSRoute Hostname Validation

Open rlymbur opened this issue 7 months ago • 0 comments

What type of PR is this?

Bug

Which issue does this PR fix:

#649

What does this PR do / Why do we need it:

This adds a validation to ensure at least one hostname is present when using a TLSRoute.

Testing done on this change:

The TLSRoute without hostname should fail unit test was added to validate the new logic.

Automation added to e2e:

None.

Will this PR introduce any new dependencies?:

No.

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

No.

Does this PR introduce any user-facing change?:

Add TLSRoute Hostname Validation

Do all end-to-end tests successfully pass when running make e2e-test?:

------------------------------

Ran 57 of 70 Specs in 3137.332 seconds
SUCCESS! -- 57 Passed | 0 Failed | 0 Pending | 13 Skipped
--- PASS: TestIntegration (3141.33s)
PASS
ok      github.com/aws/aws-application-networking-k8s/test/suites/integration   3141.993s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rlymbur avatar May 15 '25 22:05 rlymbur