aws-app-mesh-roadmap icon indicating copy to clipboard operation
aws-app-mesh-roadmap copied to clipboard

Feature Request: Rate Limiting

Open bcelenza opened this issue 5 years ago • 12 comments

Tell us about your request App Mesh should support the ability to configure rate limiting for requests coming into or out of a Virtual Node. This could be enabled by using Envoy Proxy's Global Rate Limiting. With this setting, customers could define thresholds for how many transactions (i.e. requests) per time period to allow from a given caller before throttling further traffic.

This is similar to #6 (Circuit Breaker Policy) but solves additional use cases depending on the traffic characteristics being handled by the service.

Which integration(s) is this request for? All

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

  1. Given a known set of clients calling my service, I would like to limit the amount of requests-per-second they may send before I fail the request with an error code, letting them know they have exceeded their rate limits.
  2. Given a known egress destination, I would like to limit the amount of requests-per-second I send to the destination to keep from overwhelming them, in the case that they cannot rate limit me on the server side.

bcelenza avatar Sep 13 '19 22:09 bcelenza

Hi @shubharao, I've noticed that this feature request has been accepted but it's not in the roadmap project --> https://github.com/aws/aws-app-mesh-roadmap/projects/1

Any ideas of when you guys will start working on ti?

isaac-mj avatar Jun 01 '20 21:06 isaac-mj

Hey @isaac-mj , fixed that. It is on our roadmap, but we're not actively working on it at the moment.

Is this one of interest to you? Have any requirements or thoughts you could share on what you'd want if so? :)

bcelenza avatar Jun 03 '20 20:06 bcelenza

When using Virtual Gateway as the Ingress, having API rate limiting is a very natural requirement since it's not fulfilled by NLB/ALB either. I really don't want to integrate WAF for the purpose, since in many cases calls come from internal services residing in another data centre or cloud provider.

amanullah92 avatar Dec 03 '20 06:12 amanullah92

I am also interested in this. I will probably be potentially implementing this in the coming months. Is there any way to inject arbitrary envoy config into appMesh config? I see something like that for stats and tracing, but nothing else.

Thanks

ghost avatar May 25 '21 21:05 ghost

We are also not interested in rate limiting.

jjacob27 avatar Jul 28 '21 06:07 jjacob27

+1

alexbricepalo avatar Sep 16 '21 18:09 alexbricepalo

@koresar, App Mesh does not configure any rate limitation for Envoy proxies, at does not allow for custom configuration of rate limiting at the moment. Please open a support case with the details of your environment / configuration and error logs, so our team can look into it.

herrhound avatar Feb 01 '22 02:02 herrhound

Thanks @herrhound Apologies. I confused rate limiting with something else.

koresar avatar Feb 02 '22 02:02 koresar

+1 - Would be fantastic if this was added!

amazkovoi avatar Aug 06 '23 05:08 amazkovoi

+1, this would be cool!

recreational-snacker avatar Oct 02 '23 11:10 recreational-snacker

+1 - much needed feature and other service mesh alternatives like Istio already support it.

karanb192 avatar Oct 16 '23 11:10 karanb192

+1 - any updates on this?

simano65 avatar Sep 12 '24 12:09 simano65