aws-app-mesh-controller-for-k8s icon indicating copy to clipboard operation
aws-app-mesh-controller-for-k8s copied to clipboard

can't inject env var with a comma in it's value

Open Omar-Bishtawi opened this issue 10 months ago • 4 comments

Describe the bug if you try to inject the following annotation to any deployment

appmesh.k8s.aws/sidecarEnv: '[{"sample_key_1":"value","sample_key_2":"value"}]'

you will get the follwing error

malformed annotation appmesh.k8s.aws/sidecarEnv , expected format: EnvVariableKey=EnvVariableValue

Steps to reproduce attach any json value with multiple keys to sidecar env var .

Expected outcome the env variable to have a valid json as it's value

Additional Context: I think this behavior is expected since in herethe method only split by , and we can't escape this charachter in any way.

Omar-Bishtawi avatar Aug 21 '23 11:08 Omar-Bishtawi