aws-app-mesh-controller-for-k8s icon indicating copy to clipboard operation
aws-app-mesh-controller-for-k8s copied to clipboard

Feature Request: Use injector only (no App Mesh CRDs)

Open bcelenza opened this issue 5 years ago • 1 comments

Some customer use cases will require the mesh entities to be defined outside of Kubernetes CRDs (for example, via CloudFormation). With the merge of the injector and controller in the current v1beta2 branch (and GA release candidate), two changes were made which impact this:

  1. The controller and injector are contained within a single binary. This by itself is not really an issue, and may be OK.
  2. The controller uses pod selectors instead of annotations to relate App Mesh resources to pods and inject the appropriate Envoy configuration. We could implement annotations as another optional way to configure these deployments, similar to how we did it in the original alpha controller.

bcelenza avatar Jun 11 '20 23:06 bcelenza

Seems like these are all addressed. Can this be closed?

kiranmeduri avatar Dec 07 '20 17:12 kiranmeduri