amazon-vpc-cni-k8s icon indicating copy to clipboard operation
amazon-vpc-cni-k8s copied to clipboard

Add workflow to sync cni-metrics-helper helm chart to eks-charts

Open oliviassss opened this issue 4 years ago • 5 comments

What type of PR is this? Enhancement

Which issue does this PR fix: ORR task

What does this PR do / Why do we need it: Currently, there are 3 args to run this command:

  • -b, required, which is to assign binary basename
  • -r, optional, which is the Github repot to sync to in the form of "org/name"
  • -n, optional, which is to indicate whether to include the release note in the sync PR

This PR added a workflow to sync cni-metrics-helper helm chart to eks-charts repo, by using -b to choose which helm chart to sync.

  • The user can pass 2 values to -b: aws-vpc-cni or cni-metrics-helper. If invalid value is passed the script will quit.
  • Sample command to sync aws-vpc-cni helm chart to eks-chart: bash scripts/sync-to-eks-charts.sh -b aws-vpc-cni
  • Sample command to sync cni-metrics-helper to eks-chart: bash scripts/sync-to-eks-charts.sh -b cni-metrics-helper
  • Or use make command make ekscharts-sync-release or make ekscharts-syncto sync both charts with/without release note.

Testing done on this change:

Automation added to e2e:

N/A Will this break upgrades or downgrades. Has updating a running cluster been tested?: N/A

Does this change require updates to the CNI daemonset config files to work?:

No Does this PR introduce any user-facing change?:

No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

oliviassss avatar Dec 15 '21 00:12 oliviassss

@jayanthvn sorry for the delay, please review the latest change. Have modified both make ekscharts-sync-release and make ekscharts-sync in Makefile.

oliviassss avatar Jan 13 '22 22:01 oliviassss

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

github-actions[bot] avatar Jul 09 '22 00:07 github-actions[bot]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

github-actions[bot] avatar Sep 22 '22 00:09 github-actions[bot]

Discarding this PR as this workflow is not currently needed. This can be reintroduced in the future if needed

jdn5126 avatar Oct 12 '22 14:10 jdn5126

We need to keep the PR open, it is reviewed and pending merge. This is needed to sync cni metrics helper to eks-charts.

jayanthvn avatar Oct 12 '22 15:10 jayanthvn