amazon-sagemaker-operator-for-k8s icon indicating copy to clipboard operation
amazon-sagemaker-operator-for-k8s copied to clipboard

Published 20 hours ago • verified publisher icon aws

Randomize k8s object names

Open mbaijal opened this issue 3 years ago • 0 comments
trafficstars

What does this PR do / how does this improve the operators?

This PR improves the integ tests to randomize the k8s object names of the jobs created

Which issue(s) does this PR fix?

This was leading to some issues on the non-ephemeral test runs

Fixes #

Special notes for the reviewer:

Currently only applied to the trainingjob, we can expand to other jobs if we think it is required. Code is written so this can be done easily.

Testing

Tested by running on the pipeline. trainingjob completes successfully, we will know more only when merged and runs on the non ephemeral clusters. The pipeline is still failing but with a different error.

Does this PR require changes to documentation?

No

All Submissions:

  • [ ] Have you followed the guidelines in our Contributing document?
  • [ ] Have you written or refactored unit tests to cover the change?
  • [ ] Have you ran all unit tests and ensured they are passing?
  • [ ] Have you manually tested each feature that is being added/modified?
  • [ ] Have you ensured you have not introduced linting errors?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mbaijal avatar Feb 21 '22 17:02 mbaijal