amazon-sagemaker-operator-for-k8s icon indicating copy to clipboard operation
amazon-sagemaker-operator-for-k8s copied to clipboard

Revert PR #167, PR #155, parts of PR #154. Add actual test fix: randomize endpoint name in HAP test.

Open mbaijal opened this issue 4 years ago • 0 comments
trafficstars

What does this PR do / how does this improve the operators?

  1. This reverts commit 24cd54bdf041d6e347f7d8877460ed02805b0432 (PR #167 )
  2. Reverts PR #155
  3. Reverts commented out test from PR #154
  4. Adds a random string to the endpoint name to fix the race condition (both create and update test)

[WIP] Testing

  1. Reproduced the error by reverting PR #167 and triggering two integration test runs to see that one failed.
  2. Used the same steps to then check that the fix actually works and the race condition is not reproduced.

All Submissions:

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you written or refactored unit tests to cover the change?
  • [x] Have you ran all unit tests and ensured they are passing?
  • [x] Have you manually tested each feature that is being added/modified?
  • [x] Have you ensured you have not introduced linting errors?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mbaijal avatar Feb 08 '21 20:02 mbaijal