amazon-sagemaker-examples icon indicating copy to clipboard operation
amazon-sagemaker-examples copied to clipboard

Add custom container build in SM PT Batch Inference

Open nskool opened this issue 2 years ago • 8 comments

Issue #, if available:

  1. The current notebook breaks due to a bug in the inference toolkit, that processes only one responses instead of all, while that is being fixed, updating the example to use custom container as a work-around.

Description of changes:

  1. Add custom container build and push
  2. Modify the DLC example that uses sagemaker-pytorch-inference-toolkit to use another workaround (re-archiving) the model using torch-model-archiver

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [ ] I have read the CONTRIBUTING doc and adhered to the example notebook best practices
  • [ ] I have updated any necessary documentation, including READMEs
  • [ ] I have tested my notebook(s) and ensured it runs end-to-end
  • [ ] I have linted my notebook(s) and code using tox -e black-format,black-nb-format

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nskool avatar May 11 '22 19:05 nskool

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-examples-link-check
  • Commit ID: 1e03a53eeb731e444274f5cd9ed22726d2a44941
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar May 11 '22 19:05 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-examples-grammar
  • Commit ID: 1e03a53eeb731e444274f5cd9ed22726d2a44941
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar May 11 '22 19:05 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-examples-code-formatting
  • Commit ID: 1e03a53eeb731e444274f5cd9ed22726d2a44941
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar May 11 '22 19:05 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-examples-code-formatting
  • Commit ID: 1e03a53eeb731e444274f5cd9ed22726d2a44941
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar May 11 '22 19:05 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-examples-grammar
  • Commit ID: 1e03a53eeb731e444274f5cd9ed22726d2a44941
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar May 11 '22 19:05 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-examples-link-check
  • Commit ID: 1e03a53eeb731e444274f5cd9ed22726d2a44941
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar May 11 '22 19:05 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: amazon-sagemaker-examples-pr
  • Commit ID: 1e03a53eeb731e444274f5cd9ed22726d2a44941
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar May 11 '22 19:05 sagemaker-bot