amazon-redshift-python-driver icon indicating copy to clipboard operation
amazon-redshift-python-driver copied to clipboard

Update config.py - uncommented OID 25

Open stefanks opened this issue 11 months ago • 3 comments

Hopefully solves https://github.com/aws/amazon-redshift-python-driver/issues/214

stefanks avatar Mar 19 '24 21:03 stefanks

Hey @stefanks , thanks for raising this PR. Can you share some details around the testing performed for this change. Mainly, did you confirm it resolved #214 i.e. were you able to successfully issue the query which previously was not working? If so, could you please add an integration test which issues this query so we can have coverage for this change in our CI?

Brooke-white avatar Mar 20 '24 16:03 Brooke-white

@Brooke-white not tested yet, having trouble setting up the dev environment with all the tests and stuff. I'm on a mac with vscode.

stefanks avatar Mar 21 '24 13:03 stefanks

@Brooke-white can you help me with this?

stefanks avatar Apr 25 '24 15:04 stefanks

Hi @stefanks , my apologies for my delay in response on both this issue and the associated PR. I pulled in this PR and found it did not resolve the issue at hand. This is due to the limitations around Redshift's support for array based bind parameters as I mentioned in the issue. As such, my best recommendation at this time is the work around I provided in #214

Brooke-white avatar Jun 26 '24 20:06 Brooke-white