amazon-kinesis-video-streams-parser-library icon indicating copy to clipboard operation
amazon-kinesis-video-streams-parser-library copied to clipboard

Fix big-buck-bunny and Lombok build issues

Open stefankiesz opened this issue 9 months ago • 0 comments

  • There is a bug in this version of Lombok that causes switch-cases to all turn into default cases causing "Duplicate default" compilation errors: https://github.com/projectlombok/lombok/issues/3087

    • The build is failing for Java 11, 17, and 21.
    • Although we set Lombok dependency version to 1.18.22, the lombok-maven-plugin is still on version 1.18.20. There is no newer version of lombok-maven-plugin.
    • Refactored all of the switch-case statements to be if-else blocks. Now successfully builds on Java 11. It builds successfully on Java 17 only after running mvn clean install twice. Still not supporting Java 21.
      • More investigating to do on Java 17, but this PR should completely resolve the issues for Java 11.
  • There is no file called big-buck-bunny_trailer.webm, but tests are attempting to access it.

    • Removed the test cases that use it.

ToDo:

  • Add back the bunny tests, and add in the missing file.
  • Add to the ReadMe a matrix of tested Java versions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

stefankiesz avatar May 06 '24 03:05 stefankiesz