amazon-genomics-cli icon indicating copy to clipboard operation
amazon-genomics-cli copied to clipboard

Harmonize the aws profile option

Open nh13 opened this issue 2 years ago • 3 comments

Description

I would like the --awsProfile to change to --profile to match the AWS CLI.

Use Case

To make it easier to switch between various AWS CLIs

Proposed Solution

Change this line I believe: https://github.com/aws/amazon-genomics-cli/blob/884308fc2b7e00d918c57e8a912957076309dde2/packages/cli/internal/pkg/cli/flag.go#L33

Other information

NA

nh13 avatar May 18 '22 17:05 nh13

Seems reasonable. To retain backward compatibility we would probably retain --awsProfile and call the same logic from --profile.

We use Cobra for command line parsing which in turn uses PFlag for flags. PFlag allows flag aliasing

markjschreiber avatar May 19 '22 14:05 markjschreiber

I think we originally intended AGC to have profiles hence the distinct name but that is no longer a requirement.

markjschreiber avatar May 19 '22 14:05 markjschreiber

I can try to make a PR, a first for me for Go.

nh13 avatar May 19 '22 15:05 nh13