amazon-ecs-cli icon indicating copy to clipboard operation
amazon-ecs-cli copied to clipboard

specified var/run/docker.sock directly to mount it

Open hkawa608 opened this issue 3 years ago • 0 comments

Specified the var/run/docker.sock file clearly instead of the var/run folder for the host mount configurations.

  • This file is created as a symbolic link with /Users/${username}/.docker/run/docker.sock in Mac environment.
  • With the folder mount configurations, /var/run/docker.sock is also created in a container as a symbolic link with the same path. Users or programs can not access the host's file path from inside a container, they cannot also access the socket file.
  • On the other hand, with the file mount configurations, /var/run/docker.sock is created as a genuine file, not a symbolic link. So they can access the socket file.

Fixed https://github.com/aws/amazon-ecs-cli/issues/1144


Enter [N/A] in the box, if an item is not applicable to your change.

Testing

  • [N/A] Unit tests passed
  • [N/A] Integration tests passed
  • [N/A] Unit tests added for new functionality
  • [N/A] Listed manual checks and their outputs in the comments (example)
  • [N/A] Link to issue or PR for the integration tests:

Documentation

  • [N/A] Contacted our doc writer
  • [N/A] Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hkawa608 avatar Feb 22 '22 11:02 hkawa608