amazon-ecs-cli icon indicating copy to clipboard operation
amazon-ecs-cli copied to clipboard

Published 20 hours ago • verified publisher icon aws

Add capacity provider strategy support

Open cixelsyd opened this issue 4 years ago • 1 comments

Add capacity provider support via command line flags, in the same vein as the existing target-groups support.

Addresses #1089

Hi everyone, I have not made an open source contribution before, but we want to use capacity providers with our ecs-cli implementation, so I wrote it in. I have not added any tests: I have not written golang tests before.

Enter [N/A] in the box, if an item is not applicable to your change.

Testing

  • [ ] Unit tests passed
  • [ ] Integration tests passed
  • [ ] Unit tests added for new functionality
  • [ ] Listed manual checks and their outputs in the comments (example)
  • [ ] Link to issue or PR for the integration tests:

Documentation

  • [ ] Contacted our doc writer
  • [ ] Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cixelsyd avatar Oct 09 '20 02:10 cixelsyd

@cixelsyd it looks like there was a build failure in github.com/aws/amazon-ecs-cli/ecs-cli/modules/utils. If you're still interested in taking this PR forward can you take a look and update?

allisaurus avatar Dec 08 '20 18:12 allisaurus