amazon-ecs-ami icon indicating copy to clipboard operation
amazon-ecs-ami copied to clipboard

Add ec2-instance-connect to AMI

Open dali546 opened this issue 1 year ago • 9 comments

Summary

Include ec2-instance-connect to AL2023 AMI

Implementation details

Updated the default input variables

Testing

New tests cover the changes:

Description for the changelog

Add ec2-instance-connect package to AL2023 ECS AMI

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dali546 avatar Nov 15 '23 16:11 dali546

@singholt Hi, are you able to provide a review, or assist in getting this merged?

dali546 avatar Nov 16 '23 22:11 dali546

@sparrc @chienhanlin Hi, is there any chance you could take a look at this PR?

dali546 avatar Nov 21 '23 00:11 dali546

Hello @dali546, thanks for reaching out to ECS.

As we have not supported this on ECS-optimized AL2023 AMIs, please create a feature request with more details in https://github.com/aws/amazon-ecs-ami/issues or https://github.com/aws/containers-roadmap/issues for us to work on this request. Thanks.

chienhanlin avatar Nov 22 '23 18:11 chienhanlin

Hi @chienhanlin, I have created the issue below. Thank you

https://github.com/aws/amazon-ecs-ami/issues/170

dali546 avatar Nov 22 '23 18:11 dali546

@chienhanlin There is an already existing issue here: https://github.com/aws/containers-roadmap/issues/1300

dali546 avatar Nov 24 '23 13:11 dali546

Hi @chienhanlin is there any update on this? I would very much like this to be baked in as installing it in userdata is flaky. sometimes the package fails to install, or hangs and never actually gets installed. When used as part of an EC2 Autoscaling Group, it leads to misconfigured machines being provisioned

dali546 avatar Dec 13 '23 18:12 dali546

cc @chienhanlin @amogh09 @hyandell @danehlim

dali546 avatar Jan 09 '24 20:01 dali546

@chienhanlin can you please update myself on if this PR can be merged.

dali546 avatar Feb 29 '24 17:02 dali546

@Yiyuanzzz @prateekchaudhry as recent contributors to this project, are you able to help push this through. It is a simple PR that will improve the workflow and connectivity of ECS AMIs

dali546 avatar Jun 24 '24 18:06 dali546