amazon-ecs-agent icon indicating copy to clipboard operation
amazon-ecs-agent copied to clipboard

gMSA support on Linux

Open saikiranakula-amzn opened this issue 3 years ago • 4 comments

ECS changes to support gMSA on Linux

  • changes to init module to pass environment variables to agent
  • changes to agent to return gmsa capability
  • added grpc client to communicate with credentials-fetcher daemon

Summary

Implementation details

Testing

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

saikiranakula-amzn avatar Sep 27 '22 00:09 saikiranakula-amzn

Is it possible to break this PR down into multiple short ones? 280 files changed is too much to review in 1 PR.

singholt avatar Sep 29 '22 17:09 singholt

Is it possible to break this PR down into multiple short ones? 280 files changed is too much to review in 1 PR.

FWIW, i believe it's mostly vendor dir changes

sparrc avatar Sep 29 '22 17:09 sparrc

Can you please add documentation on how to auto-gen the protobuf files?

sparrc avatar Sep 29 '22 17:09 sparrc

Is it possible to break this PR down into multiple short ones? 280 files changed is too much to review in 1 PR.

most of the changes are pulled in with gRPC reference

saikiranakula-amzn avatar Oct 06 '22 01:10 saikiranakula-amzn

Can we have provide more information, such as what are main changes, the purpose of the main changes, some minor changes (moving codes from one file to another file), how to test it, any E2E testing, ...etc on this PR to help readers review it? Thanks.

chienhanlin avatar Oct 17 '22 16:10 chienhanlin

Can we have provide more information, such as what are main changes, the purpose of the main changes, some minor changes (moving codes from one file to another file), how to test it, any E2E testing, ...etc on this PR to help readers review it? Thanks.

we are adding a blog for it and also I am wrapping up a quip for the end to end testing, will share it here as well

saikiranakula-amzn avatar Oct 18 '22 01:10 saikiranakula-amzn

closing as this has been superseded by other PRs

sparrc avatar Jan 17 '23 18:01 sparrc