amazon-cloudwatch-agent
amazon-cloudwatch-agent copied to clipboard
Fix: Provide Linux amd64 tar.gz distribution #179
Description of the issue
This is a fix for the issue #179
Description of changes
Saving tar file before creating rpm in Tools/src/create_rpm.sh
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
make make release
Requirements
Before commit the code, please do the following steps.
- Run
make fmt
andmake fmt-sh
- Run
make linter
Codecov Report
Merging #599 (c7a997e) into master (80659e2) will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 56.86% 56.87% +0.01%
==========================================
Files 374 374
Lines 17744 17743 -1
==========================================
+ Hits 10090 10092 +2
+ Misses 7063 7061 -2
+ Partials 591 590 -1
Impacted Files | Coverage Δ | |
---|---|---|
translator/util/sdkutil.go | 0.00% <0.00%> (ø) |
|
plugins/inputs/demo/demo.go | 57.14% <0.00%> (+7.14%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Thanks for the approval @khanhntd :)
I need another review to merge this. I also see merging is blocked because of build-and-test-macos / macos-unittest (pull_request) My changes are only on linux which passes the build and test
Please comment.
This PR was marked stale due to lack of activity.
This PR was marked stale due to lack of activity.
I need another review - At least 2 approving reviews are required by reviewers with write access Can you help me with this build-and-test-macos / macos-unittest Failling
Is the CI failure similar to this bug reported: https://github.com/aws/amazon-cloudwatch-agent/issues/553
Hi @varshashesh, For the build-and-test-macos, yes the attached issues are the right one. However, it is not a block for the PR to get merged. For awareness, there are some internal discussions regarding support TAR for Linux (aka this PR) so we will merge the PR after final decision has been made and thanks for the wait.
This PR was marked stale due to lack of activity.
This PR was marked stale due to lack of activity.
No plans to release tar.gz release at this time