amazon-cloudwatch-agent icon indicating copy to clipboard operation
amazon-cloudwatch-agent copied to clipboard

Rewrite ReadMe documents for building, packaging and add cache for nightly build

Open khanhntd opened this issue 3 years ago • 7 comments

Description of the issue

There are two changes in this PR:

  • Rewrite README Document for better clearance for each instruction.
  • Adding cache and make test when uploading nightly release build to s3.

Description of changes

  • Easier in reading and easier in providing instructions for customers when using our services.
  • Increasing speeding for building when uploading nightly release binaries and package to S3
  • (Optional) Ensure caching go dependencies without worrying about Github retention policies.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

N/A

Documents

For cache: https://docs.github.com/en/actions/advanced-guides/caching-dependencies-to-speed-up-workflows

khanhntd avatar Feb 04 '22 19:02 khanhntd

Codecov Report

Merging #358 (39196eb) into master (be2a6bd) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   57.31%   57.29%   -0.03%     
==========================================
  Files         370      370              
  Lines       17352    17352              
==========================================
- Hits         9946     9942       -4     
- Misses       6820     6824       +4     
  Partials      586      586              
Impacted Files Coverage Δ
plugins/outputs/cloudwatch/cloudwatch.go 74.36% <0.00%> (-0.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be2a6bd...39196eb. Read the comment docs.

codecov-commenter avatar Feb 04 '22 19:02 codecov-commenter

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Feb 17 '22 00:02 github-actions[bot]

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Feb 25 '22 00:02 github-actions[bot]

I do not see cache being added

sethAmazon avatar May 09 '22 18:05 sethAmazon

I do not see cache being added

Forgot to update it. Nice catch. Updated in the latest commit @sethAmazon

khanhntd avatar May 09 '22 18:05 khanhntd

This PR was marked stale due to lack of activity.

github-actions[bot] avatar May 17 '22 00:05 github-actions[bot]

This PR was marked stale due to lack of activity.

github-actions[bot] avatar May 31 '22 00:05 github-actions[bot]