amazon-cloudwatch-agent icon indicating copy to clipboard operation
amazon-cloudwatch-agent copied to clipboard

Published 20 hours ago • verified publisher icon aws

Add statsd.templates to the config json schema

Open matan129 opened this issue 2 years ago • 10 comments

Description of the issue

The statsd input module supports Telegraf style graphite templates, but these are blocked in the json schema.

Specifically, I've implemented this PR to resolve #172, but it adds additional capabilities to the agent beyond that (i.e. metric filtering, dynamic tagging, etc.)

Description of changes

This makes the config validator recognize the templates parameter, which is already supported by the statsd input module.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Note that the feature was already implemented, I merely enabled it to be configured.

  • Updated existing config tests
  • Added basic tests for the new field

matan129 avatar Aug 19 '21 00:08 matan129

@jefchien @pxaws I'd appreciate a review here 🙏

matan129 avatar Aug 22 '21 08:08 matan129

@ZhenyuTan-amz ?

matan129 avatar Sep 26 '21 17:09 matan129

Anyone? @haojhcwa @straussb ?

matan129 avatar Sep 29 '21 06:09 matan129

Hey Matan,

thanks for the PR! I'm going to discuss this with the team and get back to you. We need to understand a little more about the impact of statsd templates as well as the original issue in #172

jhnlsn avatar Sep 29 '21 15:09 jhnlsn

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Oct 09 '21 00:10 github-actions[bot]

@jhnlsn Any updates on your side? Currently, I keep this fork alive for internal usage in my company and it's not so fun to maintain.

matan129 avatar Nov 29 '21 08:11 matan129

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Dec 08 '21 00:12 github-actions[bot]

@jhnlsn any updates? This has been parked for a long time now.

matan129 avatar Jan 20 '22 13:01 matan129

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Jan 28 '22 00:01 github-actions[bot]

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Feb 05 '22 00:02 github-actions[bot]

We feel this is needed to have some reasonable option to define meaningful alarms on CW on the custom metrics sent by the agent.

dxciberaws avatar Nov 22 '22 10:11 dxciberaws

@jhnlsn ping

matan129 avatar Feb 21 '23 20:02 matan129

Hi @matan129, can you help us in explain the use case for the templates. However, as the original issue , there are similar PR to support global dimension and another thing to consider would be: Telegraf has a concept of global tags which also solves the original issues. The templates is similar to a band-aid to specific plugin only.

khanhntd avatar Feb 22 '23 10:02 khanhntd

It looks to me like the global dimensions PR indeed solves a superset of what my PR solves. Closing it.

matan129 avatar Feb 22 '23 11:02 matan129