amazon-chime-sdk-js icon indicating copy to clipboard operation
amazon-chime-sdk-js copied to clipboard

Replace deprecated command with environment file

Open jongwooo opened this issue 2 years ago • 0 comments

Issue #: #2622

Description of changes:

For external contributor sending a PR from a fork, currently our workflow cannot run as the GitHub secrets wont be available in the fork. Could you clone the repo and re-send the PR? But the change LGTM.

Reopen #2623

Update workflows to use environment file instead of deprecated set-output command. For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=version-number::$((${current_version%%.*} - 1))"

TO-BE

echo "version-number=$((${current_version%%.*} - 1))" >> $GITHUB_OUTPUT

Testing: N/A

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

Checklist:

  1. Have you successfully run npm run build:release locally?

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jongwooo avatar Apr 11 '23 12:04 jongwooo