amazon-chime-sdk-android icon indicating copy to clipboard operation
amazon-chime-sdk-android copied to clipboard

Background filters flip the video upside-down before joining a meeting

Open Jim-Bar opened this issue 2 years ago • 15 comments

Hi. Recently a fix was made so that it is possible to use background blur / replacement image before joining a meeting session on Android: #504. But now when using those filters before joining a meeting, the video is upside-down.

  1. Implement a blur filter
  2. Apply it to the video preview, not being in a meeting
  3. The blur is applied, but the video is upside down

The same occurs with the background replacement image.

This is actually a follow up on the comments I already posted in the original issue.

Tested on a Samsung Galaxy S20 FE, Android 12 and:

  • Amazon Chime SDK 0.17.7
  • Amazon Chime SDK Machine learning 0.1.0
  • Amazon Chime SDK Media 0.17.8

See this video:

https://user-images.githubusercontent.com/8939266/199742416-5dbc5ea7-d187-4213-8070-09bfc1fead71.mp4

Jim-Bar avatar Nov 17 '22 08:11 Jim-Bar

Thanks for reporting the issue, we will investigate it.

dingyishen-amazon avatar Nov 21 '22 17:11 dingyishen-amazon

Thank you for reporting I am able to reproduce the issue. We'll do further investigation and get back to you.

hokyungh avatar Dec 01 '22 07:12 hokyungh

This is due to flipping logic in here. I think internally it comes as flipped which works in this case, but in usual case it might not be working. We'll think of better way to fix this.

hokyungh avatar Dec 01 '22 22:12 hokyungh

All right, thank you for your investigation. We are looking forward to this bug fix.

Jim-Bar avatar Dec 02 '22 08:12 Jim-Bar

Hi, do you have news on this?

Jim-Bar avatar Jan 04 '23 11:01 Jim-Bar

HI sorry I am still working on this issue. I'll let you know when I have solution for this issue.

hokyungh avatar Jan 05 '23 19:01 hokyungh

Hi, this is still an issue for us. Has it been fixed in a new version?

Jim-Bar avatar Mar 08 '23 08:03 Jim-Bar

Hello, sorry to ping repeatedly, but this is still an issue for us. Do you have news on this?

Jim-Bar avatar Apr 27 '23 07:04 Jim-Bar

Hi sorry for late reply. Unfortunately, I was still caught up with other tasks and didn't have time to work on it. We'll let you know once we work on it, but for short-term mitigation, would it be possible to implement CustomBackgroundProcessor before joining that resembles BackgroundFilterVideoFrameProcessor.kt?

hokyungh avatar Apr 28 '23 19:04 hokyungh

@hokyungh any news on this one? It's still occurring on the latests (0.19.1) release

kackogut avatar Mar 20 '24 13:03 kackogut

I tried creating a CustomBackgroundReplacementVideoFrameProcessor, CustomBackgroundFilterVideoFrameProcessor is the same as BackgroundReplacementVideoFrameProcessor, BackgroundFilterVideoFrameProcessor file. In the CustomBackgroundReplacementVideoFrameProcessor file, replace BackgroundFilterVideoFrameProcessor with CustomBackgroundFilterVideoFrameProcessor. In the CustomBackgroundFilterVideoFrameProcessor file, add VideoRotation.Rotation180 to the VideoFrame. And it worked image

Sotatek-HungHa2 avatar Aug 20 '24 16:08 Sotatek-HungHa2

I tried creating a CustomBackgroundReplacementVideoFrameProcessor, CustomBackgroundFilterVideoFrameProcessor is the same as BackgroundReplacementVideoFrameProcessor, BackgroundFilterVideoFrameProcessor file. In the CustomBackgroundReplacementVideoFrameProcessor file, replace BackgroundFilterVideoFrameProcessor with CustomBackgroundFilterVideoFrameProcessor. In the CustomBackgroundFilterVideoFrameProcessor file, add VideoRotation.Rotation180 to the VideoFrame. And it worked image

I am getting an error while creating CustomBackgroundFilter VideoFrameProcessor there i am geting error for some functions and variables of Segment processor class how did you manage that ?

Screenshot 2024-08-27 at 12 53 42 PM

Screenshot 2024-08-27 at 12 54 19 PM

PalankiBharat avatar Aug 27 '24 07:08 PalankiBharat

I tried creating a CustomBackgroundReplacementVideoFrameProcessor, CustomBackgroundFilterVideoFrameProcessor is the same as BackgroundReplacementVideoFrameProcessor, BackgroundFilterVideoFrameProcessor file. In the CustomBackgroundReplacementVideoFrameProcessor file, replace BackgroundFilterVideoFrameProcessor with CustomBackgroundFilterVideoFrameProcessor. In the CustomBackgroundFilterVideoFrameProcessor file, add VideoRotation.Rotation180 to the VideoFrame. And it worked image

I am getting an error while creating CustomBackgroundFilter VideoFrameProcessor there i am geting error for some functions and variables of Segment processor class how did you manage that ?

Screenshot 2024-08-27 at 12 53 42 PM

Screenshot 2024-08-27 at 12 54 19 PM

Segment processor class is managed by Chime Sdk. This is the version i used image

Sotatek-HungHa2 avatar Aug 27 '24 08:08 Sotatek-HungHa2

Segment processor class is managed by Chime Sdk. This is the version i used image

I have used the same can you share with me your CustomBackgroundReplacementVideoFrameProcessor and CustomBackgroundFilterVideoFrameProcessor if that is not a problem ?

PalankiBharat avatar Aug 27 '24 09:08 PalankiBharat

CustomBackgroundReplacementVideoFrameProcessor Archive.zip

Sotatek-HungHa2 avatar Sep 12 '24 07:09 Sotatek-HungHa2