The CDK deployment method fails with `'%%VERSION%%' is not a valid value for TagValue`

[ameotoko]

Describe the bug

The README.md describes two possible ways to deploy the solution:

https://github.com/aws-solutions/video-on-demand-on-aws-foundation/blob/b921c3926385759f65e7ec95ed1f13770883bfd7/README.md?plain=1#L103

However, since %%VERSION%% was moved directly into the source code in ca3c9c18, creating stack with CDK fails with this message:

 Resource handler returned message: "'%%VERSION%%' is not a valid value for TagValue - it contains illegal characters (Service: ServiceCatalogAppRegistry, Status Code: 400"

The %%VERSION%% variable is only replaced by the build-s3-dist.sh script, which doesn't run if one chooses the CDK deploy method, hence the error.

To Reproduce Clone the repo, build the app, deploy with cdk deploy from the ./source/cdk folder.

Version: I only tested with 1.3.2, however, if I determined the cause correctly, the version introduced the bug is 1.2.1.

[raulmlamzn]

Thank you for reaching out to us regarding the issue you've encountered. We've received your ticket and our team is currently reviewing the details provided.