serverless-image-handler icon indicating copy to clipboard operation
serverless-image-handler copied to clipboard

Published 20 hours ago • verified publisher icon aws-solutions

validate image resize dimensions

Open ericbuehl opened this issue 1 year ago • 4 comments

Issue #, if available: -

Description of changes: Clients who request invalid image resize dimensions should get a 4xx error rather than a 5xx

Checklist

  • [x] :wave: I have added unit tests for all code changes.
  • [x] :wave: I have run the unit tests, and all unit tests have passed.
  • [ ] :warning: This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ericbuehl avatar Apr 14 '23 04:04 ericbuehl

@ericbuehl thank you for your submission, we will add it to our backlog for evaluation and get back to you. sorry about the delay in responding.

dougtoppin avatar Apr 28 '23 15:04 dougtoppin

hello -- any updates here?

ericbuehl avatar Jun 26 '23 22:06 ericbuehl

@dougtoppin any updates here? thank you!

ericbuehl avatar Jun 29 '23 16:06 ericbuehl

Hi @ericbuehl,

As an update here, we've decided to implement this change. It would be considered a breaking change, so we've marked it to be included in the next major release. While our internal policy has us make the changes manually, once the release is out, you'll see your profile and this PR referenced in the External Contributors section towards the bottom of the readme, and this PR will be closed.

Thanks for your contributions to the Serverless Image Handler :) Simon

simonkrol avatar Mar 19 '24 13:03 simonkrol