quota-monitor-for-aws icon indicating copy to clipboard operation
quota-monitor-for-aws copied to clipboard

Slack Notification - Disable - CFN Fails Validation

Open jchinyou opened this issue 4 years ago • 5 comments

Instructions Incorrect (https://docs.aws.amazon.com/solutions/latest/limit-monitor/deployment.html#step1)

In the section about Slack Notification Levels:

Choose the status event level(s) that will trigger Slack notifications. For example, “WARN”, “ERROR”. Note that the format is double quotation marks and comma separated (for multiple values). Note Leave this parameter blank if you do not want to receive Slack notifications. Note that the Slack notification components will not be deployed.

However if left Blank, the Cloudformation template fails validation, citing SlackRole Dependency check

jchinyou avatar Nov 10 '20 18:11 jchinyou

@jchinyou Hello! Did you leave all 1,2 and 3 parameters blank or only 1?

  1. Slack Notification Level
  2. Slack Hook URL Key Name
  3. Slack Channel Key Name

rakshb avatar Nov 16 '20 15:11 rakshb

@rakshb Hello!

Confirmed! I left all Slack inputs blank. The CFN then fails on dependency.

jchinyou avatar Nov 18 '20 14:11 jchinyou

@jchinyou Thank you for reporting this. Looks like if you leave "Slack Notification Level" parameter blank and remove the default values of "WARN","ERROR", it throws this error. We will fix this issue in a future release, to make sure that all 3 Slack parameters can be left blank if the option is not needed by customers

rakshb avatar Nov 18 '20 15:11 rakshb

Same problem here.

I've applied successfully this temporary workaround:

  • Remove the row #426 (""Condition": "SlackTrue""), used for "SlackNotifierRole" resource
@@ -422,8 +422,7 @@
             }
           ]
         }
-      },
-      "Condition": "SlackTrue"
+      }
     },
     "SlackNotifierRoleDefaultPolicy3F0FB2C2": {
       "Type": "AWS::IAM::Policy",

davcen avatar Jan 11 '21 12:01 davcen

Hi,

Can also add "Condition": "SlackTrue" for SlackNotifierRoleDefaultPolicy3F0FB2C2 ressource to solve the issue.

pproux avatar Apr 01 '21 10:04 pproux

updated in v6.0.0

gsingh04 avatar Oct 12 '22 20:10 gsingh04