qnabot-on-aws icon indicating copy to clipboard operation
qnabot-on-aws copied to clipboard

Resource LambdaAccessRole in CF not being used.

Open antonykattarath opened this issue 2 years ago • 1 comments

Resource LambdaAccessRole in CF not being used/referred anywhere else in cf script. Can it be removed? Also this role is having lambda full access and it's trusted identity is API gateway, Why do API gateway requires full access to lambda?

antonykattarath avatar Dec 01 '21 05:12 antonykattarath

Hey @antonykattarath thanks for notifying us about this. I looked through the source code. Seems like you are right. We'll have to do some testing with LambdaAccessRole removed to make sure removing it won't introduce breaking changes. If testing goes well, we'll have this role removed in future updates.

mohsenari avatar Dec 06 '21 19:12 mohsenari

Will be included in the next release.

ihmaws avatar Jul 19 '23 19:07 ihmaws

@antonykattarath I will be closing this. This should be addressed in the latest release (5.4.1)

michaelin-96 avatar Aug 17 '23 18:08 michaelin-96