instance-scheduler-on-aws icon indicating copy to clipboard operation
instance-scheduler-on-aws copied to clipboard

Published 20 hours ago • verified publisher icon aws-solutions

MultiplyWaitStrategy - incorrect name

Open ilyash-b opened this issue 5 years ago • 8 comments

MultiplyWaitStrategy should be named ExponentialWaitStrategy or something similar.

See https://en.wikipedia.org/wiki/Exponential_backoff

ilyash-b avatar Mar 22 '19 09:03 ilyash-b

We might change it later but is used in other solutions as well. If you want to use a name that complies to your naming conventions you can fork the repo and change its name

arieleeuw avatar Mar 22 '19 10:03 arieleeuw

your naming conventions

The whole world's naming convention. This naming is plainly a bug. Nobody calls it that way.

you can fork the repo and change its name

I don't care, you can close the issue. I just looked at the code and reported a bug.

ilyash-b avatar Mar 22 '19 11:03 ilyash-b

Thanks for your feedback, we’ll consider it for future development

arieleeuw avatar Mar 22 '19 13:03 arieleeuw

@arieleeuw You suggestion to fork the code is interesting and completely unproductive. I agree that there naming and convection issues, of confusing or things that are understood flat out wrong. MultiplyWaitStrategy and ExponentialWaitStrategy don't mean the same things. In fact, MultiplyWaitStrategy means nothing to me.

zglozman avatar Mar 22 '19 18:03 zglozman

@maykays, it would be nice to have a reason for closing this issue.

ilyash avatar Aug 23 '20 20:08 ilyash

@ilyash - this issue was closed based on your comment above "I don't care, you can close the issue." However, it seems you still feel strongly about this issue. I'm re-opening the issue and we'll take another look.

maykays avatar Aug 24 '20 14:08 maykays

I'll summarize my position.

  • This is a bug
  • Denying that this is a bug - not OK
  • Saying that I suggest "name that complies to your naming conventions" - not OK
  • Suggesting fork - not OK
  • Closing the issue without a comment - meh
  • Closing the issue saying "It's a bug but we won't fix it because ..." - OK (it's your project)
  • Fixing the issue - great

ilyash-b avatar Aug 25 '20 13:08 ilyash-b

My company is saving $$$ on our EC2 instances using this great solution (thanks AWS). Don't get the point of arguing, or even bother, about some internal function names that do not affect the functionality of the program at all (so why is this a bug?). Functionality is what matters to us.

AWS please keep coming with more solutions like this.

Alex WSG Prague

alex1969-prog avatar Aug 25 '20 13:08 alex1969-prog