improving-forecast-accuracy-with-machine-learning icon indicating copy to clipboard operation
improving-forecast-accuracy-with-machine-learning copied to clipboard

build-and-test dependencies install issues

Open athewsey opened this issue 3 years ago • 1 comments

Trying to build the CDK from source today I encountered a couple of (small) issues:

(1) - In the source/infrastructure/README we seem to be inconsistent about what folder the commands are run from? first cding to source/infrastructure but then running pip install -r source/requirements-build-and-test.txt.

I found that in order for pip to resolve the editable dependencies like -e cdk_solution_helper_py/helpers_cdk, I had to be inside the source folder and run pip install -r requirements-build-and-test.txt.

(2) - For some reason I don't quite understand, pip errored out due to conflict between [email protected] requiring click>=8.0.0... Even though in the requirements-build-and-test.txt, the version for black is left unspecified. Not sure what's going on here with the dependency resolution as I'd have expected it to just pick a version of black that satisfies the other constraints... But for now I worked around it by explicitly requesting black==21.12b0.

athewsey avatar Feb 22 '22 07:02 athewsey

Hello @athewsey -

Thanks for your feedback. I've confirmed the issues and will ensure that these are fixed for the next maintenance release of the solution. For now, your workaround in (2) is appropriate, and you are correct about (1) - the documentation will be fixed.

pwrmiller avatar Feb 28 '22 14:02 pwrmiller