distributed-load-testing-on-aws
distributed-load-testing-on-aws copied to clipboard
Do more cleanup on delete
Description of changes: This change will:
- cleanup files from the storage bucket when scenario's are deleted
- delete result files after a configurable amount of days (default: 10 years)
- delete non-current versions in s3 after a configurable amount of days (default: 1 year)
This seemed to use as a good compromise between things that are easy to delete (the test scripts) and things that would need an s3 list-objects (results, where we use a lifecycle instead)
I also included a script to look for resources for test that were already deleted
Checklist
- [] :wave: I have run the unit tests, and all unit tests have passed.
- [X] :warning: This pull request might incur a breaking change.
Unit tests: They passed when run on our fork, but currently fail. Unit tests on the main branch also fail for me, so it seems unrelated to this change. I can rebase this branch after the main branch is fixed.
Breaking change: Debatable, it is a change in behaviour, but I don't think anyone would be relying on files sticking around for that long
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.