aws-control-tower-customizations icon indicating copy to clipboard operation
aws-control-tower-customizations copied to clipboard

Removing a CFN template parameter doesn't trigger the change

Open akefirad opened this issue 3 years ago • 1 comments
trafficstars

Describe the bug In a CFN StackSet, when I remove a parameter which has a default value (different from what I set previously), the stack-set doesn't get updated. (Consequently stack instances won't be updated either.)

To Reproduce In my case, I tried to deploy CDK Toolkit stack using the official template (generated via the CLI):

  1. Add the template, and set the required parameters. The one I tried was the qualifier, set a value abcdef123 other than the default one (which is hnb659fds).
  2. Deploy the resources. All resources get created. All good.
  3. Now remove the qualifier parameter, which essentially should change its value to the default one (which is different with what is deployed).
  4. Push the changes. Nothing changes.

Please complete the following information about the solution:

  • [X] Version: v2.3.0

  • [x] Region: eu-central-1

  • [x] Was the solution modified from the version published on this repository? No!

  • [ ] If the answer to the previous question was yes, are the changes available on GitHub?

  • [x] Have you checked your service quotas for the sevices this solution uses? #N/A

  • [x] Were there any errors in the CloudWatch Logs? Nope!

Additional context To be clear I'm not sure if this is a bug or feature. And I'm not even sure if this is the behavior of CfCT or CFN or something else.

Thanks.

akefirad avatar Apr 29 '22 06:04 akefirad

Hey @akefirad

I was able to reproduce this bug in our test environments. I've created a backlog item to improve the logic regarding input parameters.

Thanks for bringing this to our attention!

stumins avatar May 03 '22 23:05 stumins