sagemaker-run-notebook icon indicating copy to clipboard operation
sagemaker-run-notebook copied to clipboard

added commands in dockerfile to install git

Open arvy-p opened this issue 2 years ago • 2 comments

Issue #, if available:

Description of changes: I have updated Dockerfile with RUN commands to have git installed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

arvy-p avatar Mar 10 '22 05:03 arvy-p

One question regarding this.

Should git be installed before the following command?

RUN pip install papermill jupyter nteract-scrapbook boto3 requests && pip install -r /tmp/requirements.txt

In case there are git commands in requirements.txt

fjpa121197 avatar Mar 14 '22 18:03 fjpa121197

Sorry, I'm getting to this late.

What is the motivation for having git in the default container? Is it a requirement for a common use case here? At container build time or container run time?

tomfaulhaber avatar Oct 11 '22 19:10 tomfaulhaber