sagemaker-run-notebook icon indicating copy to clipboard operation
sagemaker-run-notebook copied to clipboard

Jupyterlab extension script for Studio is incompatible

Open seanpmorgan opened this issue 3 years ago • 1 comments

v0.20 adds support for jupyterlab v2 and drops support for v1. Since studio is still on v1 we should keep the installation script pinned to 0.19

seanpmorgan avatar Jan 12 '22 16:01 seanpmorgan

Just tested this, the start.sh script does not work with the default version of juypterlab in sagemaker as a lifecycle configuration:

2022-01-12T22:19:11.655-08:00	Collecting https://github.com/aws-samples/sagemaker-run-notebook/releases/download/v0.20.0/sagemaker_run_notebook-0.20.0.tar.gz Downloading https://github.com/aws-samples/sagemaker-run-notebook/releases/download/v0.20.0/sagemaker_run_notebook-0.20.0.tar.gz (64 kB) Preparing metadata (setup.py): started Preparing metadata (setup.py): finished with status 'done'

2022-01-12T22:19:11.655-08:00	Requirement already satisfied: boto3>=1.10.44 in ./anaconda3/envs/JupyterSystemEnv/lib/python3.7/site-packages (from sagemaker-run-notebook==0.20.0) (1.20.25)

2022-01-12T22:19:11.655-08:00	Requirement already satisfied: botocore<1.24.0,>=1.23.25 in ./anaconda3/envs/JupyterSystemEnv/lib/python3.7/site-packages (from boto3>=1.10.44->sagemaker-run-notebook==0.20.0) (1.23.25)

2022-01-12T22:19:11.655-08:00	Requirement already satisfied: s3transfer<0.6.0,>=0.5.0 in ./anaconda3/envs/JupyterSystemEnv/lib/python3.7/site-packages (from boto3>=1.10.44->sagemaker-run-notebook==0.20.0) (0.5.0)

2022-01-12T22:19:11.655-08:00	Requirement already satisfied: jmespath<1.0.0,>=0.7.1 in ./anaconda3/envs/JupyterSystemEnv/lib/python3.7/site-packages (from boto3>=1.10.44->sagemaker-run-notebook==0.20.0) (0.10.0)

2022-01-12T22:19:11.655-08:00	Requirement already satisfied: urllib3<1.27,>=1.25.4 in ./anaconda3/envs/JupyterSystemEnv/lib/python3.7/site-packages (from botocore<1.24.0,>=1.23.25->boto3>=1.10.44->sagemaker-run-notebook==0.20.0) (1.26.7)

2022-01-12T22:19:11.905-08:00	Requirement already satisfied: python-dateutil<3.0.0,>=2.1 in ./anaconda3/envs/JupyterSystemEnv/lib/python3.7/site-packages (from botocore<1.24.0,>=1.23.25->boto3>=1.10.44->sagemaker-run-notebook==0.20.0) (2.8.2)

2022-01-12T22:19:11.905-08:00	Requirement already satisfied: six>=1.5 in ./anaconda3/envs/JupyterSystemEnv/lib/python3.7/site-packages (from python-dateutil<3.0.0,>=2.1->botocore<1.24.0,>=1.23.25->boto3>=1.10.44->sagemaker-run-notebook==0.20.0) (1.16.0)

2022-01-12T22:19:12.905-08:00	Building wheels for collected packages: sagemaker-run-notebook Building wheel for sagemaker-run-notebook (setup.py): started Building wheel for sagemaker-run-notebook (setup.py): finished with status 'done' Created wheel for sagemaker-run-notebook: filename=sagemaker_run_notebook-0.20.0-py3-none-any.whl size=68779 sha256=ecfdd86929a17f9de4898f470430d0bc48790cdc36c10e2f900597bc67bde654 Stored in directory: /home/ec2-user/.cache/pip/wheels/0e/bb/75/ab97750fcde4102926b1864a0fab7580cd2cf72ca6045ded16

2022-01-12T22:19:17.424-08:00	Successfully built sagemaker-run-notebook

2022-01-12T22:19:17.674-08:00	Installing collected packages: sagemaker-run-notebook

2022-01-12T22:19:20.677-08:00	Successfully installed sagemaker-run-notebook-0.20.0

2022-01-12T22:19:20.677-08:00	[LabBuildApp] WARNING | Config option `kernel_spec_manager_class` not recognized by `LabBuildApp`.

2022-01-12T22:19:20.677-08:00	[LabBuildApp] JupyterLab 1.2.21

2022-01-12T22:19:22.178-08:00	[LabBuildApp] Building in /home/ec2-user/anaconda3/envs/JupyterSystemEnv/share/jupyter/lab

2022-01-12T22:19:22.447-08:00	[LabBuildApp] Building jupyterlab assets (build:prod:minimize)

2022-01-12T22:19:22.447-08:00	[LabBuildApp] WARNING |

2022-01-12T22:19:22.447-08:00	"[email protected]" is not compatible with the current JupyterLab

IamJasonBian avatar Jan 13 '22 06:01 IamJasonBian

This will be fixed by rolling forward to JupyterLab 3 in the next release.

tomfaulhaber avatar Oct 19 '22 17:10 tomfaulhaber

v0.22.0 is now released with JupyterLab 3.x support. The new lifecycle script fixes this issue.

tomfaulhaber avatar Oct 22 '22 01:10 tomfaulhaber