observability-with-amazon-opensearch icon indicating copy to clipboard operation
observability-with-amazon-opensearch copied to clipboard

WIP refactor: Requirements.txt and upgrades in dependencies

Open ibrahimcesar opened this issue 1 year ago • 0 comments

WIP: I'm trying to test as much I could on the environment but I need some help to cover all services. Use the branch refactor/requirements

Description of changes:

Addressing some code refactor changes.

I did a upgrade on sample-apps/02-otel-collector/kubernetes/02-deployment.yaml that I not sure if is needed, but I bumped the image for the latest in Docker registry:

-      - image: otel/opentelemetry-collector:0.46.0
+      - image: otel/opentelemetry-collector:0.60.0

The sample-apps/05-databaseService/requirements.txt had two mysql-connector dependencies. I removed the old, only with the change in #24 , that I also changed in the client service.

-      mysql-connector==2.2.9
       mysql-connector-python==8.0.30

Most of the services had dependencies on dash and mysql-connector. Dash I drop the use on client service and they not use it, and not use any mysql calls — Please double check if I'm not mistaken.

-     dash==2.3.1
-     mysql-connector==2.2.9

The overall upgrade was:

+      opentelemetry-exporter-otlp==1.12.0
+      opentelemetry-instrumentation-flask==0.33b0
+      opentelemetry-instrumentation-mysql==0.33b0
+      opentelemetry-instrumentation-requests==0.33b0
+      opentelemetry-instrumentation-logging==0.33b0
+      opentelemetry-sdk==1.12.0
+      flask==2.2.2

from

-      opentelemetry-exporter-otlp==1.9.1
-      opentelemetry-instrumentation-flask==0.28b1
-      opentelemetry-instrumentation-mysql==0.28b1
-      opentelemetry-instrumentation-requests==0.28b1
-      opentelemetry-instrumentation-logging==0.28b1
-      opentelemetry-sdk==1.9.1
-      flask==2.0.2

The dependency protobuf==3.15.6 is needed in the requirements.txt? I'm not a Python expert and would like to know. Is the only dependency I did not bump or deleted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ibrahimcesar avatar Sep 26 '22 14:09 ibrahimcesar