aws-secrets-manager-rotation-lambdas icon indicating copy to clipboard operation
aws-secrets-manager-rotation-lambdas copied to clipboard

Published 20 hours ago • verified publisher icon aws-samples

Clarify expected behavior if test stage fails

Open mdavis-xyz opened this issue 3 years ago • 1 comments

Please modify the docstring comment for the test_secret function.

What is my code supposed to do if the test fails? Do I return False, or throw an exception? If an exception, which exception?

mdavis-xyz avatar Oct 05 '21 23:10 mdavis-xyz

Thank you for your feedback. We have noted this as a feature request.

whygoyal avatar Mar 02 '22 20:03 whygoyal

Hi mdavis. We expect that there are exceptions raised for any errors encountered. Which particular exceptions are irrelevant to Secrets Manager - we're tracking that the testSecret step failed, the rest would show up in your CloudWatch logs for debugging.

jbct avatar May 15 '23 18:05 jbct

Ok, thanks for the explanation.

As someone in the target audience, that wasn't what I expected. So I've written a PR to clarify that.

mdavis-xyz avatar May 16 '23 01:05 mdavis-xyz