aws-secrets-manager-rotation-lambdas icon indicating copy to clipboard operation
aws-secrets-manager-rotation-lambdas copied to clipboard

Would be nice to be able to change the Runtime for the rotation function

Open umairrahmad opened this issue 3 years ago • 2 comments

Here is the yaml configuration for deploying the AWS::Serverless::Application

  RDSSecretRotationService:
    Type: "AWS::Serverless::Application"
    Properties:
      Location:
        ApplicationId: arn:aws:serverlessrepo:region:id:applications/SecretsManagerRDSPostgreSQLRotationSingleUser
        SemanticVersion: 1.0.117
      Parameters:
        endpoint: !Sub "https://secretsmanager.${AWS::Region}.${AWS::URLSuffix}"
        functionName:
          Fn::Join:
            - ""
            - - Fn::ImportValue: !Sub ${ClusterImportPrefix}-ClusterResolvingName
              - "-rds-rotation-lambda"
        vpcSubnetIds:
          Fn::ImportValue: !Sub ${VPCImportPrefix}-PrivateSubnets
        vpcSecurityGroupIds: !Ref RDSSecurityGroup

where can the documentation for the parameter list supported by this AWS resource (AWS::serverless::application)

I tried to add both

        Runtime: "python3.7"
        runtime: "python3.7"

failed to do so

umairrahmad avatar Jun 10 '21 10:06 umairrahmad

Thank you for your feedback. The SAM template does not currently take Runtime as a parameter. We have noted this as a feature request.

joebaro avatar Jul 02 '21 22:07 joebaro

For people landing here, you can upgrade by changing the

SemanticVersion: 1.0.117

umairrahmad avatar Jul 29 '21 09:07 umairrahmad

Secrets Manager now supports RunTime Key from CFN template. Please refer to this article here

goyalya avatar May 22 '23 18:05 goyalya