aws-genai-llm-chatbot icon indicating copy to clipboard operation
aws-genai-llm-chatbot copied to clipboard

Enhancement: record full prompt in the feedback record

Open massi-ang opened this issue 1 year ago • 3 comments

The user feedback feature introduced in #287 records the user feedback with the following format:

{"feedbackId": "d7911ac5-36e1-449e-ba27-766bb1fdb997", "sessionId": "7d78bb7c-dfd6-4b70-b16c-fd34af42b435", "userId": "xxxxx", "key": "5", "prompt": "About Charle Magn", "completion": "  Sure, I can help with that! Here's a brief overview of Charles Magn:\n\nCharles Magn was a French inventor and engineer who is best known for his work on the first practical typewriter. He was born in 1827 and died in 1909. Magn's typewriter was patented in 1874 and featured a QWERTY keyboard layout that has since become the standard for typewriters and computer keyboards.", "model": "meta.llama2-13b-chat-v1", "feedback": "1", "createdAt": "2024-02-12T21:37:47.881565Z"}

Note that the prompt field contains only the user question, and not the full prompts sent to the LLM, which would consist of a prompt template formatted with the chat history and the user question.

By only recording the user question, the data will not be useful for fine tuning of the model.

We want to record the full prompt, and possibly also the prompt template and template arguments values.

massi-ang avatar Feb 13 '24 07:02 massi-ang

@azaylamba Hi Ajay, would you like to take a stab at this since you submitted the PR on user feedback?

massi-ang avatar Feb 13 '24 07:02 massi-ang

Sure @massi-ang, I will look into this in a couple of days.

azaylamba avatar Feb 13 '24 10:02 azaylamba

I think this one can be closed with merge last week

ryanh-ai avatar Mar 30 '24 05:03 ryanh-ai

This issue is stale because it has been open for 60 days with no activity.

github-actions[bot] avatar May 30 '24 01:05 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar Jul 12 '24 01:07 github-actions[bot]