aws-cudos-framework-deployment icon indicating copy to clipboard operation
aws-cudos-framework-deployment copied to clipboard

Published 20 hours ago • verified publisher icon aws-samples

add scad to cur

Open iakov-aws opened this issue 10 months ago • 2 comments

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

iakov-aws avatar Apr 23 '24 11:04 iakov-aws

@iakov-aws I'm looking forward to getting this PR ready and merged into the main branch!

BTW, applying the changes from the branch as of now is resulting into this error message:

ValidationError: Parameters: [AddSCAD] do not exist in the template

MaximF avatar Apr 24 '24 23:04 MaximF

@iakov-aws I created a PR https://github.com/aws-samples/aws-cudos-framework-deployment/pull/808 to your current branch to activate SPLIT_COST_ALLOCATION_DATA. Could you please take a look?

MaximF avatar May 02 '24 17:05 MaximF

@iakov-aws could you please rebase this MR to fix the terraform-scan. You already merged the woraround. And is something else missing? I'm looking forward to deploy SCAD over the tf-module

yamb00 avatar May 14 '24 11:05 yamb00

Not sure what is needed AWS is a member of FinOps foundation but the site says it is not. Help in the processs would be appreaciated

iakov-aws avatar May 15 '24 05:05 iakov-aws