aws-blockchain-node-runners icon indicating copy to clipboard operation
aws-blockchain-node-runners copied to clipboard
verified publisher icon aws-samples

Bitcoin Core Implementation

Open racket2000 opened this issue 8 months ago • 1 comments

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

More

  • [x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [x] Mandatory for new node blueprints. Yes, I have added usage example to the README.md file in my blueprint folder
  • [x] Mandatory for new node blueprints. Yes, I have implemented automated tests for all stacks in my blueprint and they pass
  • [x] Mandatory for new node blueprints. Yes, I have added a reference to my README.md file to website/docs section for this feature
  • [x] Yes, I have set up and ran all pre-merge quality control tools on my local machine and they don't show warnings.

For Moderators

  • [x] The tests for all current blueprints successfully complete before merge?
  • [x] Mandatory for new node blueprints. All pre-merge quality control tools and cdk-nag tools don't show warnings?
  • [x] Mandatory for new node blueprints. The deployment test works on blank AWS account according to instructions in the README.md before merge?
  • [x] Mandatory for new node blueprints. The website builds without errors?

Additional Notes

N/A

racket2000 avatar Apr 01 '25 15:04 racket2000

When opening this PR, I initially kept encountering a "forbidden error" regarding the "camelcase" package for the Website Build check. I am not sure why. (An example of this error message can be seen here: https://github.com/aws-samples/aws-blockchain-node-runners/actions/runs/14201779886/job/39790220182)

Apologies for the numerous commits I made to troubleshoot this -- I had to do a bit of trial and error to refresh my package.json and package-lock.json in order to get past the Website Build check (which is strange, since the "camelcase" package is utilized in the website's package-lock.json)

For clarity, I am using a few packages for Bitcoin, such as aws-sdk/client-secrets-manager and base64url.

I have created a local package.json for Bitcoin, since the other Blueprints do not require these dependencies.

racket2000 avatar Apr 01 '25 17:04 racket2000

Closing this original PR, as I have refactored the Bitcoin Core implementation to align better with existing blueprints.

Link: https://github.com/aws-samples/aws-blockchain-node-runners/pull/207

racket2000 avatar Jun 11 '25 18:06 racket2000